Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option setting the direction of switching workspace #348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add an option setting the direction of switching workspace #348

wants to merge 1 commit into from

Conversation

demokritos
Copy link

Workspace-to-dock extension allows the workspaces to lay in horizontal direction. If workspaces are in horizontal direction, switching workspace by scrolling on the dock does not work. This PR adds a checkbox for horizontal workspace switching in the preference and a switcher popup source code from the Workspace-to-dock extension.

@micheleg
Copy link
Owner

Hi,

thanks for your contribution. I had a look at the code and everything seems to make sense. However, I'm a bit puzzle about the inclusion of such feature. I'm wondering if there's a way for workspace-to-dock to be more compatible without requiring change in other extensions.

I'll have to think a bit about it.

@passingthru67
Copy link
Contributor

@demokritos, I probably should have made the workspaces-to-dock horizontal switching an alternative instead of the default. Anyway, I can add an option that will give users a choice.

@demokritos
Copy link
Author

OK.
Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants